Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added start position args #200

Merged
merged 9 commits into from
Mar 4, 2022
Merged

Added start position args #200

merged 9 commits into from
Mar 4, 2022

Conversation

generein
Copy link
Contributor

@generein generein commented Mar 4, 2022

Proposed changes

Add an azimuth_start_angle to all types of TF coil components

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Member

shimwell commented Mar 4, 2022

This looks great thanks @generein
I've approved the CI run (required for PRs from forks) and now the tests will run to check that these changes don't break the code
I guess it will be fine

@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #200 (b26e056) into develop (7df8970) will increase coverage by 44.70%.
The diff coverage is 100.00%.

❗ Current head b26e056 differs from pull request most recent head a4920a3. Consider uploading reports for the commit a4920a3 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #200       +/-   ##
============================================
+ Coverage    52.14%   96.85%   +44.70%     
============================================
  Files           77       77               
  Lines         4886     4898       +12     
============================================
+ Hits          2548     4744     +2196     
+ Misses        2338      154     -2184
Impacted Files Coverage Δ
...tric_components/toroidal_field_coil_coat_hanger.py 100.00% <100.00%> (+70.37%) ⬆️
...tric_components/toroidal_field_coil_princeton_d.py 100.00% <100.00%> (+73.56%) ⬆️
...metric_components/toroidal_field_coil_rectangle.py 100.00% <100.00%> (+71.15%) ⬆️
...ic_components/toroidal_field_coil_round_corners.py 93.88% <100.00%> (+69.86%) ⬆️
...etric_components/toroidal_field_coil_triple_arc.py 100.00% <100.00%> (+83.33%) ⬆️
paramak/parametric_shapes/extruded_mixed_shape.py 100.00% <0.00%> (+2.17%) ⬆️
paramak/shape.py 94.76% <0.00%> (+2.24%) ⬆️
paramak/parametric_components/cutting_wedge_fs.py 98.78% <0.00%> (+7.31%) ⬆️
...k/parametric_components/poloidal_field_coil_set.py 100.00% <0.00%> (+7.54%) ⬆️
paramak/reactor.py 77.04% <0.00%> (+11.60%) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df8970...a4920a3. Read the comment docs.

@shimwell
Copy link
Member

shimwell commented Mar 4, 2022

🎉 congrats all the tests passed, this can be merged in.

I shall add docstrings and a test later

Thanks for the contribution

@shimwell shimwell changed the base branch from main to develop March 4, 2022 17:31
@shimwell shimwell merged commit 04776ff into fusion-energy:develop Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimwell shimwell shimwell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@generein @shimwell